Adding in filter for 3D model of cathode for systematics#926
Open
jzennamo wants to merge 3 commits intoproduction/v10_06_00from
Open
Adding in filter for 3D model of cathode for systematics#926jzennamo wants to merge 3 commits intoproduction/v10_06_00from
jzennamo wants to merge 3 commits intoproduction/v10_06_00from
Conversation
Contributor
Author
|
OK, so, using cosmic data I created a 3D representation of the cathode, I integrated that into SBNDCode and tried to create a version of the gdml that removes the cathode. This was validated using cosmic MC and is ready to be merged and used to generate a systematic variation. |
tbwester
reviewed
Apr 29, 2026
Contributor
tbwester
left a comment
tbwester
left a comment
There was a problem hiding this comment.
Overall implementation looks good. Personally I prefer a larsoft service with centralized, sbnd-level cathode config file instead of configuring within the filter fhicl. I can't comment on the GDML nor jsonnet files.
| install_fhicl(SUBDIRS fcl) | ||
| cet_enable_asserts() | ||
|
|
||
| # install sbnd_pds_mapping.json with mapping of the photon detectors |
Contributor
There was a problem hiding this comment.
Did you consider making this a larsoft service? Then this could be used elsewhere with unified experiment-defined configuration (not just set in the filter configuration fhicl)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a detailed description of the changes this pull request introduces.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?